ID-198, 194: new layers on frontend #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpetrov02
approved these changes
Dec 24, 2023
Contributor
lpetrov02
left a comment
lpetrov02
left a comment
There was a problem hiding this comment.
Я не шарю за фронт, но нейминг меня устраивает!
AntoxaBarin
approved these changes
Dec 24, 2023
Contributor
AntoxaBarin
left a comment
AntoxaBarin
left a comment
There was a problem hiding this comment.
Выглядит нормально. Самое главное - протестировать всё: выбор входов, отправка новых параметров. Нужно чтобы это всё работало
Contributor
Можешь Axes number добавить паддинг справа еще плиз. Ну и блин конечно в идеале еще бы провалидировать чтобы введенные номера осей хотя бы не совпадали между собой, но можно забить |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new layers, fixed axes, removed icons